Add 'cam_note' and 'tel_note' to command payloads #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All good, thanks.
Sent from WER iPhone.
…On Tue, Oct 8, 2024 at 4:16 PM Tim Beccue ***@***.***> wrote:
The cam_note already existed under a different name, so I renamed those
occurrences.
I added tel_note to the telescope command tab.
- cam_note and tel_note are both keys in the optional_params dict that
is part of the command payload
- they are not included if the value is an empty string
- tel_note is only considered if the mount command is the ‘go’ command
(all green circled buttons in the attached screenshot). tel_note is never
included for the other mount commands (red circled buttons in screenshot)
like park, slew to flat position, etc.
Screenshot.2024-10-08.at.7.06.30.PM.png (view on web)
<https://github.com/user-attachments/assets/c376228b-2a53-4ec2-b826-bbd6c3c775b8>
------------------------------
You can view, comment on, or merge this pull request online at:
#164
Commit Summary
- 994f616
<994f616>
Change "camera_note" to "cam_note" in camera command payload
- 2c2a189
<2c2a189>
Add tel_note to mount commands
File Changes
(5 files <https://github.com/LCOGT/ptr_ui/pull/164/files>)
- *M* src/components/InstrumentControls/Camera.vue
<https://github.com/LCOGT/ptr_ui/pull/164/files#diff-41ae6987e66cecbea33cc14c702ee2c8c8bb3c6c17a383b8d54cbba361b58cb3>
(10)
- *M* src/components/InstrumentControls/Telescope.vue
<https://github.com/LCOGT/ptr_ui/pull/164/files#diff-e8928bbf15a3e51f8c2bd7baf72a89ac1e97ef7fdea350fe1e9a7c5290e00e46>
(16)
- *M* src/components/sitepages/SiteObserve.vue
<https://github.com/LCOGT/ptr_ui/pull/164/files#diff-f8ed1d15116dacfe7003fec7351e68b489e288c6ae5fb5af5549fc4b24387894>
(6)
- *M* src/mixins/commands_mixin.js
<https://github.com/LCOGT/ptr_ui/pull/164/files#diff-b7aedf7870a67fbc488c34232d09f20529e0d79e1e6e06ea17c26620a95b9d72>
(43)
- *M* src/store/modules/command_params.js
<https://github.com/LCOGT/ptr_ui/pull/164/files#diff-fe5010d8a15dcebbbcf634f6365f6234427448bdddaeb4c7b9c0a8fedc16230d>
(9)
Patch Links:
- https://github.com/LCOGT/ptr_ui/pull/164.patch
- https://github.com/LCOGT/ptr_ui/pull/164.diff
—
Reply to this email directly, view it on GitHub
<#164>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTZ3MBJ2IFTVFQCZUDM6WDZ2RRVZAVCNFSM6AAAAABPTJNFHCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3TIMZZGQZTONQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
mgdaily
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cam_note already existed under a different name, so I renamed those occurrences.
I added tel_note to the telescope command tab.